fix(android): improve error handling for external storage file access #14442
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add better error handling and logging for Android external storage paths - Provide more descriptive error messages when file access fails - Check file existence and permissions before attempting to open files - Helps diagnose issues with accessing files in /storage/emulated/0/Android/data/ paths Fixes tauri-apps#14432
Author
|
@FabianLars Can you review this PR? |
FabianLars
reviewed
Nov 10, 2025
Member
FabianLars
left a comment
FabianLars
left a comment
There was a problem hiding this comment.
thanks for the pr :) a few ideas since most of your code should offer value on other platforms as well, not just android.
Author
|
@FabianLars Thanks for the review . Ill use your suggestions! |
- Make file existence and metadata checks platform-agnostic (not Android-only) - Remove verbose debug logging that doesn't add value - Simplify error messages to reduce spam - Keep Android-specific context only where necessary
Author
|
@FabianLars Ive changed in the latest commits whats have been asked can you review it now? |
FabianLars
reviewed
Nov 12, 2025
| // Check if we have read permissions | ||
| if let Err(e) = std::fs::metadata(&path) { | ||
| log::error!("Failed to get metadata for {}: {}", path, e); | ||
| return resp.status(500).body(format!("Failed to access file metadata: {}", e).into_bytes().into()).map_err(Into::into); |
Member
There was a problem hiding this comment.
maybe we shouldn't use 500 here since that's our fallback on any kind of error. Any other ideas? 403 comes to mind but we already use that above 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 500 error when accessing local video files in Android external storage directory via
convertFileSrc. Added better error handling and logging for Android external storage access to help diagnose permission and accessibility issues.Closes #14432
.changesdirectory