Patch for the Window menu to enable the Fullscreen button

[Jerakin]

In theory fixes #3

This is a bit tricky to fix in a good way, and we really need to consider if we need this kind of complexity. It wouldn't surprise me if there are other locations that needs similar fixes.

How this is fixed here is by finding the current "Window" menu and unregistering the class. We then register our custom menu class that has the same class name. This overwrites the menu.

As we need to fully replace the menu this adds complexity as if Blender adds a or removes from the menu our own menu will get out dated.

What do you think @hannesdelbeke, is this complexity really worth it? I am on the fence, feels excessive to me.

p.s.
This does not resolve that any fullscreen hotkey might not work.

Other ways I tried.

Register a new operator with the same name.

Since Blender 3.5 this is no longer possible and doing it raises an error.

Unregister the current operator.

It's impossible to unregister builtin (c++) operators.

---

I did ask about this as a Blender Bug and did request a feature to easier overwrite existing operators on rightclickselect

[hannesdelbeke]

nobody mentioned this as an issue since 2019. that's 7 years. not worth introducing complexity i think. but i am kinda interested in the approach, i ll revisit when i have time

[hannesdelbeke]

i especially like that this is a separate python file, it's clean, containing the complexity

[Jerakin]

Yeah, it's just something that came up at work. It's pretty much a non-issue but if there are other locations/features/buttons not working this might be something we can revisit. Personally I don't think it's worth it just to get this one menu button to work.

[hannesdelbeke]

another thing is that qt windows can disable the buttons making them window-bar-less
so we could always create 3 qt buttons and implements min max close buttons ourselves. but would then also need to implement drag n drop

[Jerakin]

Ooof that brings me back to when I was helping on qtmodern. We wanted a borderless window and required us to re-implement a ton of things, while it could make it look pretty it was very much an headache.