Escape braces in literals - #150
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the presence of a brace
{or}in a literal doesn't break the parser by adding braces to the set of characters that can be escaped, if necessary.Revamping escape handling led to it becoming permissible to have escapes in tablet labels. It's not something you'd need most of the time, but there is no reason to prohibit them and this means now the code is simpler with just one string-ish parsing path.
Testing with content in a mutliline literal inadvertently led us to realize that we had (as is ever the case) inconsistent handling of embedded tab characters. Bloody things strike again. Decided to have the formatter normalize tabs to four spaces on output.