Instruct rpminspect to ignore xml jinja templates#4635
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
LecrisUT
approved these changes
Mar 3, 2026
The `_base.xml.j2` template is incorrectly detected as `xml` and then always reported as a problem when releasing a new `tmt` in Fedora. Let's get rid of the false warning.
psss
force-pushed
the
psss-rpminspect-and-jinja
branch
from
e6c9800 to
45fe574
Compare
vaibhavdaren
approved these changes
Mar 5, 2026
Contributor
Author
|
Let's get rid of those irrelevant failures, proposing for the current sprint. |
Contributor
It shouldn't be even needed to be proposed for a sprint, it should be grabbed by the current release person when there's nothing better to get merged. It's reviewed, it's ready to get in. Successful story points, free of charge. Edit: added to agenda, this should be a task for the release person, "from time to time check merge orphans". |
Contributor
|
No change in code, just packaging file, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_base.xml.j2template is incorrectly detected asxmland then always reported as a problem when releasing a newtmtin Fedora. Let's get rid of the false warning.