Add runtime type information to worker heartbeats - #809
Conversation
10bd610 to
ed4d70d
Compare
Opengrep — new findings
Suppress findingsAdd a |
| RUNTIME_TYPE_BUN = 4; | ||
| RUNTIME_TYPE_RUBY = 5; | ||
| RUNTIME_TYPE_GO = 6; | ||
| RUNTIME_TYPE_DOCKER = 7; |
There was a problem hiding this comment.
Is there more than one type possible? Like python in docker?
There was a problem hiding this comment.
the field in the heartbeat is repeated, so we can include multiple
// be repeated for scenarios like "Python inside a Lambda".
There was a problem hiding this comment.
Actually, does it make sense to have RuntimeType type = 1; to be repeated here? Would we expect the version of multiple runtimes in the heartbeat to diverge, or will they always be the same?
f8e6470 to
f36da6e
Compare
| ARCHITECTURE_ARM64 = 2; | ||
| } | ||
|
|
||
| message Platform { |
There was a problem hiding this comment.
Should there be an UnspecifiedPlatform in case someone is running on something that isn't Windows, Linux, or MacOS (e.g. BSD). Idk if we'd want an optional name field (so then is it really unspecified?) and version. Maybe named OtherPlatform?
There was a problem hiding this comment.
OtherPlatform makes sense
|
This might sit for a bit since @rkannan82 wants to possibly line it up with the register worker API |
|
Relates to temporalio/sdk-typescript#1964 |
f1377e0 to
016062a
Compare
70eb7b7 to
db48ba7
Compare
db48ba7 to
7cb4bb3
Compare
|
We're no longer gonna wait on register to be created first |
What changed?
Title
Why?
Help us understand customer environments. SDKs will include an opt-out flag.
Breaking changes
Server PR