Add REQUEST_TOO_LARGE workflow task failed cause and expose completion size limit - #838
Merged
Conversation
jmaeagle99
approved these changes
Jul 22, 2026
prathyushpv
approved these changes
Jul 29, 2026
fretz12
pushed a commit
that referenced
this pull request
Jul 29, 2026
…on size limit (#838) **What changed?** Added `WORKFLOW_TASK_FAILED_CAUSE_REQUEST_TOO_LARGE` to the workflow task failed cause enum. Added `NamespaceInfo.Limits.workflow_task_completion_size_limit_error` to communicate the server-enforced max RespondWorkflowTaskCompleted request size via DescribeNamespace. **Why?** When a workflow task completion exceeds the server's size limit we currently fail with the generic `PAYLOADS_TOO_LARGE`, which is misleading (no single payload is oversized). The new cause names the actual condition, and exposing the limit lets SDKs stay under it instead of discovering it by failing. **Breaking changes** None. Additive-only **Server PR** TODO
5 tasks
simvlad
added a commit
to temporalio/temporal
that referenced
this pull request
Jul 31, 2026
…e limit (#11377) ## What changed? - Workflow task completion buffer overflow now fails the WFT with `WORKFLOW_TASK_FAILED_CAUSE_REQUEST_TOO_LARGE` instead of `PAYLOADS_TOO_LARGE`. - `DescribeNamespace` reports `NamespaceInfo.Limits.workflow_task_completion_size_limit_error`, sourced from `history.workflowTaskCompletionBufferSizeLimit`. API PR: temporalio/api#838 ## Why? `PAYLOADS_TOO_LARGE` is misleading here, no single payload is oversized, the request total is. Exposing the limit lets SDKs page under it instead of discovering it by failing. ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) ## Potential risks No
smuneebahmad
pushed a commit
to temporalio/temporal
that referenced
this pull request
Aug 3, 2026
…e limit (#11377) ## What changed? - Workflow task completion buffer overflow now fails the WFT with `WORKFLOW_TASK_FAILED_CAUSE_REQUEST_TOO_LARGE` instead of `PAYLOADS_TOO_LARGE`. - `DescribeNamespace` reports `NamespaceInfo.Limits.workflow_task_completion_size_limit_error`, sourced from `history.workflowTaskCompletionBufferSizeLimit`. API PR: temporalio/api#838 ## Why? `PAYLOADS_TOO_LARGE` is misleading here, no single payload is oversized, the request total is. Exposing the limit lets SDKs page under it instead of discovering it by failing. ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) ## Potential risks No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added
WORKFLOW_TASK_FAILED_CAUSE_REQUEST_TOO_LARGEto the workflow task failed cause enum. AddedNamespaceInfo.Limits.workflow_task_completion_size_limit_errorto communicate the server-enforced max RespondWorkflowTaskCompleted request size via DescribeNamespace.Why?
When a workflow task completion exceeds the server's size limit we currently fail with the generic
PAYLOADS_TOO_LARGE, which is misleading (no single payload is oversized). The new cause names the actual condition, and exposing the limit lets SDKs stay under it instead of discovering it by failing.Breaking changes
None. Additive-only
Server PR
TODO