Add request IDs to activity update, unpause, and reset - #844
Merged
Conversation
dandavison
reviewed
Jul 29, 2026
Comment on lines
+2186
to
2189
| // Run ID of the workflow or standalone activity. If empty, targets the latest run. | ||
| // For standalone activities, specify a run ID to avoid retrying a different | ||
| // execution when the activity ID is reused. | ||
| string run_id = 4; |
Contributor
There was a problem hiding this comment.
I think it's hard to explain and the comment risks making it more confusing, not less. (what is "retrying"?) I vote we just follow SANO and keep it to
Suggested change
| // Run ID of the workflow or standalone activity. If empty, targets the latest run. | |
| // For standalone activities, specify a run ID to avoid retrying a different | |
| // execution when the activity ID is reused. | |
| string run_id = 4; | |
| // Run ID of the workflow or standalone activity. If empty, targets the latest run. | |
| string run_id = 4; |
Contributor
Author
There was a problem hiding this comment.
yea it's hard to explain a corner in a field doc. I'll simplify
dandavison
reviewed
Jul 29, 2026
Comment on lines
+2256
to
+2263
| // Run ID of the workflow or standalone activity. | ||
| // Run ID of the workflow or standalone activity. If empty, targets the latest run. | ||
| // For standalone activities, specify a run ID to avoid retrying a different | ||
| // execution when the activity ID is reused. |
Contributor
There was a problem hiding this comment.
As above, I vote we follow SANO and leave it at
// Run ID of the workflow or standalone activity. If empty, targets the latest run.
dandavison
reviewed
Jul 29, 2026
| // Resource ID for routing. Contains "workflow:{workflow_id}" for workflow activities or "activity:{activity_id}" for standalone activities. | ||
| string resource_id = 9; | ||
|
|
||
| // Used to de-dupe update requests within the targeted execution. |
Contributor
There was a problem hiding this comment.
I can't think of a reason to say "within the targeted execution". How would a user be going wrong if they read "Used to de-dupe update requests"?
Suggested change
| // Used to de-dupe update requests within the targeted execution. | |
| // Used to de-dupe update requests. |
Contributor
Author
There was a problem hiding this comment.
Related to clarifying a corner as state in RunID above. I'll simplify
dandavison
reviewed
Jul 29, 2026
Comment on lines
+2268
to
+2275
| // Used to de-dupe pause requests. | ||
| // Used to de-dupe pause requests within the targeted execution. |
Contributor
There was a problem hiding this comment.
As above, I vote we keep it simple
// Used to de-dupe pause requests.
dandavison
reviewed
Jul 29, 2026
| // Resource ID for routing. Contains "workflow:{workflow_id}" for workflow activities or "activity:{activity_id}" for standalone activities. | ||
| string resource_id = 10; | ||
|
|
||
| // Used to de-dupe unpause requests within the targeted execution. |
dandavison
reviewed
Jul 29, 2026
Comment on lines
+2404
to
+2406
| // Run ID of the workflow or standalone activity. If empty, targets the latest run. | ||
| // For standalone activities, specify a run ID to avoid retrying a different | ||
| // execution when the activity ID is reused. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Run ID of the workflow or standalone activity. If empty, targets the latest run. | |
| // For standalone activities, specify a run ID to avoid retrying a different | |
| // execution when the activity ID is reused. | |
| // Run ID of the workflow or standalone activity. If empty, targets the latest run. |
ditto
Contributor
There was a problem hiding this comment.
same comments apply below
dandavison
approved these changes
Jul 29, 2026
fretz12
force-pushed
the
fredtzeng/saa-req-id
branch
from
July 29, 2026 21:46
662b26d to
bbac65a
Compare
spkane31
reviewed
Jul 30, 2026
| string namespace = 1; | ||
| string activity_id = 2; | ||
| // Activity run ID, targets the latest run if run_id is empty. | ||
| // Activity run ID. If empty, targets the latest run. |
Contributor
There was a problem hiding this comment.
For consistency, do you want to remove the "Specify a run ID to avoid retrying ...." from RequestCancel and Terminate?
spkane31
approved these changes
Jul 30, 2026
GregoryTravis
approved these changes
Jul 30, 2026
fretz12
enabled auto-merge (squash)
July 30, 2026 20:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added request_id fields to update, unpause, and reset activity execution requests. Also clarified the run_id and request_id documentation for related activity APIs, including how omitted run IDs affect targeting and how request IDs are scoped to targeted executions.
Why?
To support idempotent retries within the targeted activity execution, prevent duplicate mutations after ambiguous timeouts or failures, and make run-targeting and request-deduplication behavior clearer to API users.