Skip to content

Allow usage of HPAs #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
purkhusid wants to merge 3 commits into
base: main
Choose a base branch
from
+26 −7
Open

Allow usage of HPAs #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9854d4
Allow usage of HPAs
purkhusid May 26, 2025
648ea8f
Merge branch 'main' into allows-usage-of-hpa
purkhusid Feb 9, 2026
d5aeef3
Test
purkhusid Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion charts/temporal/templates/server-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ metadata:
labels:
{{- include "temporal.resourceLabels" (list $ $service "deployment") | nindent 4 }}
spec:
replicas: {{ default $.Values.server.replicaCount $serviceValues.replicaCount }}
{{- if $serviceValues.replicaCount }}
replicas: {{ default $serviceValues.replicaCount }}
{{- else if $.Values.server.replicaCount }}
replicas: {{ default $.Values.server.replicaCount }}
{{- end }}
{{- with (default $.Values.server.deploymentStrategy $serviceValues.deploymentStrategy) }}
strategy:
{{- toYaml . | nindent 4 }}
Expand Down
2 changes: 2 additions & 0 deletions charts/temporal/templates/web-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ metadata:
labels:
{{- include "temporal.resourceLabels" (list $ "web" "deployment") | nindent 4 }}
spec:
{{- if .Values.web.replicaCount }}

@robholland robholland Dec 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with is cleaner here to avoid repeating the setting path.

replicas: {{ .Values.web.replicaCount }}
{{- end }}
selector:
matchLabels:
app.kubernetes.io/name: {{ include "temporal.name" $ }}
Expand Down
19 changes: 16 additions & 3 deletions charts/temporal/tests/server_deployment_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,19 @@ tests:
- equal:
path: spec.replicas
value: 3
- it: omits replica count when neither service specific nor service wide is set
template: templates/server-deployment.yaml
documentSelector:
path: metadata.name
value: RELEASE-NAME-temporal-frontend
set:
server:
replicaCount: null
frontend:
replicaCount: null
asserts:
- notExists:
path: spec.replicas
- it: defaults to service wide resources
template: templates/server-deployment.yaml
documentSelector:
Expand Down Expand Up @@ -310,9 +323,9 @@ tests:
server:
history:
readinessProbe:
initialDelaySeconds: 300
tcpSocket:
port: rpc
initialDelaySeconds: 300
tcpSocket:
port: rpc
asserts:
- equal:
path: spec.template.spec.containers[0].readinessProbe.initialDelaySeconds
Expand Down
6 changes: 3 additions & 3 deletions charts/temporal/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ server:
tag: 1.29.2
pullPolicy: IfNotPresent
# Global default settings (can be overridden per service)
replicaCount: 1

@robholland robholland Dec 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave this here (especially the comment). Just comment out the setting.

readinessProbe: {}
# replicaCount: 1
# readinessProbe: {}
metrics:
# Annotate pods and services directly with the following Prometheus annotations.
# prometheus.io/job
Expand Down Expand Up @@ -440,7 +440,7 @@ admintools:
web:
# additionalInitContainers: []
enabled: true
replicaCount: 1
# replicaCount: 1
image:
repository: temporalio/ui
tag: 2.42.1
Expand Down