Skip to content

feat(activity): report activity reset in the heartbeat RPC response - #842

Open
rustatian wants to merge 2 commits into
masterfrom
feature/activity-reset
Open

rustatian wants to merge 2 commits into
masterfrom
feature/activity-reset

Conversation

@rustatian

@rustatian rustatian commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Reason for This PR

closes: roadrunner-server/roadrunner#2249

Description of Changes

The temporal.RecordActivityHeartbeat RPC response has a new reset field. It is true when the server reset the running activity, so the PHP SDK (v2.19+) throws ActivityResetException. Before this change a reset reached the PHP worker as canceled: true.

Add release-please. Pushes to master open and update a release PR; merging it creates the tag and the GitHub release. The manifest starts at the current tag, v6.0.0.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

The heartbeat RPC response has a new "reset" field.
It is true when the server reset the activity.
The PHP SDK throws ActivityResetException for it.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 10, 2026 10:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@rustatian rustatian self-assigned this Oct 10, 2026
Release PRs and tags come from the release-please action.
The manifest starts at the current tag, v6.0.0.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[💡 FEATURE REQUEST]: Temporal: Activity reset

3 participants