Repository navigation
test: cover the timer summary from NewTimer to the TimerStarted event - #843
Merged
Merged
Conversation
The NewTimer command maps the PHP TimerOptions summary into
workflow.TimerOptions since v5.9.0. Add a codec decode test for the
`{"ms", "summary"}` wire shape and an acceptance test that reads the
summary back from the TimerStarted event user metadata.
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
rustatian
force-pushed
the
feat/timer-summary-tests
branch
from
October 10, 2026 21:37
7bbdce8 to
843dd98
Compare
rustatian
added this pull request to stack #844
October 10, 2026 21:38
wolfy-j
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for This PR
closes: roadrunner-server/roadrunner#2151
The
NewTimercommand already maps the PHP SDKTimerOptionssummary intoworkflow.TimerOptions(since v5.9.0), and the go-sdkTimerOptionshas no other field. The plugin test suite did not cover that path.Description of Changes
NewTimerwire shape the PHP SDK sends:{"ms": N}with and withoutsummary.TimerSummaryWorkflow, a PHP test workflow that starts a timer withTimerOptions::new()->withSummary(...).Test_TimerSummaryProto, which runs that workflow and reads the summary back from theTimerStartedevent user metadata.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
git commit -s).CHANGELOG.md.