Cap openai-agents at <0.17.1 to unblock test-latest-deps - #1512
Closed
xumaple wants to merge 1 commit into
Closed
Conversation
openai-agents 0.17.1 added a `timeout` parameter to `SynchronousMultiTracingProcessor.shutdown`, causing basedpyright to report `reportIncompatibleMethodOverride` on our `_TemporalTracingProcessor` override in `_temporal_trace_provider.py`. This was breaking the `test-latest-deps` CI job on main and every open PR. Cap the dependency at <0.17.1 so the resolver stays on 0.17.0 (which still has `shutdown(self) -> None`). When we want to support 0.17.1+, update the override signature to forward `timeout` and lift the cap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openai-agents0.17.1 (released today) added atimeoutparameter toSynchronousMultiTracingProcessor.shutdown, which makes basedpyright reportreportIncompatibleMethodOverrideon_TemporalTracingProcessor.shutdownintemporalio/contrib/openai_agents/_temporal_trace_provider.py. This is breaking thetest-latest-depsCI job onmainand on every open PR.Cap the dependency at
<0.17.1so the resolver stays on0.17.0(which still has the oldshutdown(self) -> None). When we want to support 0.17.1+, update the override to accept and forwardtimeoutand lift the cap.Test plan
poe lint(basedpyright/pyright/mypy/ruff/pydocstyle) passes against pinned 0.14.8poe lintpasses afteruv lock --upgrade(resolver picks 0.17.0, no override mismatch)uv run pydoctor --quietpasses🤖 Generated with Claude Code