Skip to content

fix: revert testmodule proto gen to mypy-protobuf 3.3.0 format #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tconley1428 merged 2 commits into from
Jul 30, 2026
Merged

fix: revert testmodule proto gen to mypy-protobuf 3.3.0 format #1699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4741f9c
fix: revert testmodule proto gen to mypy-protobuf 3.3.0 format
jmaeagle99 Jul 30, 2026
f32ce6f
fix: add tests dir to git diff check
jmaeagle99 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ jobs:
- run: poe gen-protos
- name: Check generation unchanged
run: |
[[ -z $(git status --porcelain temporalio) ]] || (git diff temporalio; echo "Protos changed"; exit 1)
[[ -z $(git status --porcelain temporalio tests) ]] || (git diff temporalio tests; echo "Protos changed"; exit 1)
- name: Test with protobuf 3.x
run: poe test -s --ignore=tests/contrib/google_adk_agents/
env:
Expand Down
40 changes: 19 additions & 21 deletions tests/worker/workflow_sandbox/testmodules/proto/proto_message_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions tests/worker/workflow_sandbox/testmodules/proto/proto_message_pb2.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,18 @@ isort:skip_file

import builtins
import sys
import typing

import google.protobuf.descriptor
import google.protobuf.duration_pb2
import google.protobuf.message

if sys.version_info >= (3, 10):
if sys.version_info >= (3, 8):
import typing as typing_extensions
else:
import typing_extensions

DESCRIPTOR: google.protobuf.descriptor.FileDescriptor

@typing.final
class SomeMessage(google.protobuf.message.Message):
DESCRIPTOR: google.protobuf.descriptor.Descriptor

Expand All @@ -31,10 +29,10 @@ class SomeMessage(google.protobuf.message.Message):
some_duration: google.protobuf.duration_pb2.Duration | None = ...,
) -> None: ...
def HasField(
self, field_name: typing.Literal["some_duration", b"some_duration"]
self, field_name: typing_extensions.Literal["some_duration", b"some_duration"]
) -> builtins.bool: ...
def ClearField(
self, field_name: typing.Literal["some_duration", b"some_duration"]
self, field_name: typing_extensions.Literal["some_duration", b"some_duration"]
) -> None: ...

Global___SomeMessage: typing_extensions.TypeAlias = SomeMessage
global___SomeMessage = SomeMessage
Loading