Add Event Groups in Core SDK - #1308
Draft
mjameswh wants to merge 1 commit into
Draft
Conversation
mjameswh
force-pushed
the
event-groups-feature
branch
3 times, most recently
from
June 16, 2026 16:37
efc2325 to
704b293
Compare
mjameswh
force-pushed
the
event-groups-feature
branch
from
July 13, 2026 22:08
704b293 to
53faa2b
Compare
mjameswh
force-pushed
the
event-groups-feature
branch
from
August 6, 2026 23:03
db0f6f3 to
11120cc
Compare
mjameswh
commented
Aug 6, 2026
| input: Vec::from_payloads(a.input), | ||
| identity: a.identity, | ||
| headers: a.header.map(Into::into).unwrap_or_default(), | ||
| originating_event_id: 0, |
Contributor
Author
There was a problem hiding this comment.
This will get replaced by the actual value by the caller.
I'm not happy with that, but the event_id is stored on the parent type of WorkflowExecutionSignaledEventAttributes. Could either add a type wrapper around XxxAttributes, or use a custom FromXxx trait that gets both the attributes and it's parent history event, but both approaches would be quite invasive. Not something we should do in this PR.
So I'm settling to this for now, unless anyone has objections or suggestions.
mjameswh
commented
Aug 6, 2026
| input: self.data.input, | ||
| identity: String::new(), | ||
| headers: self.data.headers, | ||
| originating_event_id: 0, |
Contributor
Author
There was a problem hiding this comment.
JWH: who sets the actual value on this one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Introduces support for Event Groups in Core SDK. Surfacing that API properly in Rust SDK will be done in a distinct PR.
More specifically, this PR introduces the following two critical changes:
event_group_markersfield from lang'sCommand→ server'sCommand.event_idorupdate_idfield from server'sHistoryEvent→ lang'sJob.Why?
Event Groups is a new form of metadata that allows regrouping of logically related Workflow Events, according to user-defined or system-inferred criteria, providing users with improved visibility, analysis, and debugging capabilities.
Related PRs in other repositories
Before merging
The
integ-testsjob pinsCLI_VERSION_OVERRIDEtov1.7.4-standalone-nexus-operations, because no official CLI release yet bundles a server that understands the Event Groups fields. That pin must be dropped once one does.