Detect Nexus operation changes during replay - #1405
Open
JSap0914 wants to merge 4 commits into
Open
Conversation
|
|
Sushisource
reviewed
Jul 15, 2026
Sushisource
left a comment
Member
There was a problem hiding this comment.
Thanks for this! Makes perfect sense. I think adding an integration test would be great and then we can merge.
Member
|
@JSap0914 Looks like you need to run the formatter |
Signed-off-by: JSup <hanjisang0914@gmail.com>
Signed-off-by: JSup <hanjisang0914@gmail.com>
Sushisource
approved these changes
Jul 23, 2026
Sushisource
enabled auto-merge (squash)
July 23, 2026 16:44
Member
|
@JSap0914 We'll need you to sign the CLA too :) |
Member
|
@JSap0914 - we can merge this if you sign the CLA. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
NexusOperationScheduledhistory events with the command produced during replayWhy
The Nexus operation state machine accepted scheduled history events without validating their service or operation. This allowed workflow code to change either field during replay without raising the non-determinism error used by comparable activity and child-workflow state machines.
Fixes #1231
Tests
cargo test -p temporalio-sdk-core nexus_operation_state_machine::tests --libcargo test -p temporalio-sdk-core --lib(367 passed, 1 ignored)cargo clippy -p temporalio-sdk-core --lib --tests --all-features -- -D warningscargo fmt --all --checkgit diff --check