Make integration test task queues unique - #2280
Draft
THardy98 wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared integration-test helper currently derives task queue names only from AVA test titles. That is safe with an ephemeral server, but concurrent CI runs against one persistent Cloud namespace can create workers on identical queues and consume each other's workflow tasks.
This change retains the readable normalized title prefix and appends a UUID whenever the shared helper creates a task queue. It truncates the prefix on UTF-8 character boundaries so the complete name stays within Temporal's 1,000-byte limit. Local tests keep the same naming shape with an added uniqueness suffix; workflow IDs remain independently randomized.
Focused coverage verifies uniqueness, readable prefixes, the server length limit, and multi-byte truncation. The seven combined Cloud-foundation AVA tests pass. The package TypeScript build reaches only the two pre-existing
ActivityExecutionStatus.PAUSEDerrors on current main.Part of temporalio/features#851.