Remove default namespace assumptions from integration tests - #2287
Draft
THardy98 wants to merge 2 commits into
Draft
Remove default namespace assumptions from integration tests#2287THardy98 wants to merge 2 commits into
THardy98 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared integration harness selects the configured environment, but several assertions and secondary clients still implicitly used the local
defaultnamespace. In Cloud, the external-storage clients sent workflow starts todefault, which the API key cannot access; failed starts then left created workers holding native connection references.This propagates the environment namespace into those clients and expected external-storage targets. It also makes intentionally unpolled or rejected alternate task queues unique to their workflow. Local behavior is unchanged, while persistent Cloud namespaces no longer fail authorization or risk cross-run interference.
Focused ESLint, Prettier, and
git diff --checkpass. The Cloud discovery run provided the failing secondary-client evidence.