fix: Ensure JSONPBEncoder terminates empty slice with ].
#8664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This fixes an issue in the
JSONPBEncoderwhich does not close the opening[with a]when encoding an empty slice. The fix was to move the line which emitted]outside of the for loop.Why?
While working on another project which uses the
JSONPBEncoderI saw that an empty slice was getting encoded as[.How did you test it?
Potential risks
I'm not too familiar with the OSS temporal code, but I would not imagine there would be anything that would be dependent on invalid json being emitted.