Conversation
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add opt-in
--max-pending-paymentsand--max-pending-generalbudgets so an accumulated general backlog cannot consume the payment submission budget. Existing shared-limit behavior remains the default.The experiment supports independent Tempo expiring-nonce transactions only. It uses
is_payment_v2for signed and deferred requests, omits offers to a full class before submission while continuing to feed the other class, and pauses the bounded input stream when both budgets are full. Inclusion, definite rejection, and chain-observed expiry release only the matching class's slot. Per-class pending and throttled-offer metrics make this behavior observable; setup is not classified or omitted.Profile
The existing public-mix benchmark still shows a throughput dip with a 10k general pool cap because transactions evicted from the node remain outstanding in txgen until inclusion or expiry. This tests sender-side isolation without changing the node or nominal workload mix.
Verification
cargo +nightly clippy -p bench-core -p bench-cli -p txgen-tempo --all-targets -- -D warningspasses.cargo test -p bench-core -p bench-cli -p txgen-tempo --lib --bins --tests -- --skip replays_a_mixed_corpus_identically_twicepasses (one pre-existing ignored test); formatting and the per-class metric test also pass. The excluded Anvil RPC-replay test fails the same response-kind assertion on the unchanged base revision.Prompted by: @klkvr