Repository navigation
fix(build): preserve consumer environment checks - #374
Merged
Merged
Conversation
Contributor
📦 Snapshot releasePublished |
Merged
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasty's browser-targeted package build folded
NODE_ENVto"development", enabling development diagnostics and instrumentation in production consumers. Preserve the environment checks in the published package with an explicit self-definition ofprocess.env.NODE_ENV, leaving the consuming app's bundler or runtime to resolve it.The runtime debug controls were introduced deliberately, and the SSR diagnostic was added with the global CSS deduplication fix. Keep both source implementations unchanged: normal production startup is quiet, while development and an explicit
TASTY_DEBUGflag retain their diagnostics. Includes a patch changeset.Regression coverage checks emitted code in fresh development, production, and test processes, then bundles and minifies a production browser consumer to verify that
TASTY_DEBUGsurvives optimization with and without a process shim. The check fails against the original package, which reportsdevMode: trueunderNODE_ENV=production.Validation:
pnpm typecheck,pnpm lint,pnpm format:checkpnpm build,pnpm size(all existing limits pass)pnpm test: 109 files and 2,563 tests passpnpm knip,pnpm check:test-only,pnpm check:buildpnpm check:react-compat: packed runtime and declarations pass with React 18.3.1 and 19.1.1 in development and production, using Node 22TASTY_DEBUG; the SSR token appears once and resolves to the expected computed padding in both process-shim variants