This repository was archived by the owner on May 28, 2024. It is now read-only.
Fix stack overflow of bash when copying tf headers#92
Open
mareikethies wants to merge 1 commit intotensorflow:masterfrom
Open
Fix stack overflow of bash when copying tf headers#92mareikethies wants to merge 1 commit intotensorflow:masterfrom
mareikethies wants to merge 1 commit intotensorflow:masterfrom
Conversation
maxrohleder
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
I experienced the same issue on powershell with msys2 base.exe enabled. With the proposed changes, it works like a charm.
I would never have discovered the stackoverflow as this line:
0 [] bash 1410 cygwin_exception::open_stackdumpfile: Dumping stack trace to bash.exe.stackdump
was missing in the log on powershell...
Thank you so much for this @mareikethies!
|
This would also totally help my project! There might be other issues down the line and we would be glad to track and fix them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue described in #87. Putting together the copy command for tf headers in tf_configure.bzl using " && " causes a stack overflow in msys2 bash.exe on windows. Executing each copy as a single command (via "\n") prevents this.