Build custom Docker image for releases #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craigacp
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
javadocbinary coming in JDK11 is buggy and fails to generate documentation on valid comments (e.g. multi-line code blocks with@annotationsin it).All other official release of Maven docker images based on JDK17 have failed so far, for other reasons. So to unblock more easily the 1.0.0 release, we'll use a custom docker image that uses the JDK11 image as its base, then installs JDK17 on it, which is used for building the release in JDK11 compatibility mode.
So the doc is generated properly and the compiled classes remain compatible with JDK11.