Add configurable winpass_timeout for Windows password reset and migrate Chefstyle to Cookstyle#139
Merged
Stromweld merged 4 commits intoJul 2, 2026
Conversation
added 4 commits
July 1, 2026 10:30
Fixes an issue where the Windows password reset operation would timeout
with 'Timeout::Error: Timeout while waiting for password agent to perform
password reset' on instances that take longer to initialize the password
agent.
Added a new 'winpass_timeout' configuration option (defaults to nil) that
allows users to specify a custom timeout (in seconds) for the gcewinpass
password reset operation. When not set, the default timeout from gcewinpass
is used, preserving backward compatibility.
Usage in kitchen.yml:
driver:
winpass_timeout: 300
Fixes: test-kitchen#117
Signed-off-by: Sachin Jain <Sachin.jain@chef.io>
Switch linting dependency from chefstyle to cookstyle (~> 8.7) and update Rakefile to use cookstyle/chefstyle require pattern, aligning with other test-kitchen plugins (e.g. kitchen-ec2). Signed-off-by: Sachin Jain <Sachin.jain@chef.io>
Signed-off-by: Sachin Jain <Sachin.jain@chef.io>
Fix 5 auto-correctable offenses detected by cookstyle: - Layout/HashAlignment: align hash keys in update_windows_password - Style/RedundantReturn: remove redundant return in image_url Signed-off-by: Sachin Jain <Sachin.jain@chef.io>
sanjain-progress
marked this pull request as ready for review
July 2, 2026 10:59
Stromweld
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
winpass_timeoutconfiguration option to allow users to specify a custom timeout (in seconds) for the Windows password reset operation performed bygcewinpass.This fixes the
Timeout::Error: Timeout while waiting for password agent to perform password reseterror that occurs when the GCE Windows password agent takes longer than the default timeout to initialize.Changes
winpass_timeoutconfig option (defaults tonil, preserving backward compatibility)GoogleComputeWindowsPasswordExample
kitchen.ymlBefore (without
winpass_timeout)After (with
winpass_timeout: 300)Related Issue
Fixes #117