Skip to content

feat: Update Lowkey Vault module #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

feat: Update Lowkey Vault module #148

merged 1 commit into from
Oct 22, 2025

Conversation

@nagyesta
Copy link
Contributor

@nagyesta nagyesta commented Aug 21, 2025

  • Set more specific category
  • Add logo
  • Add Java variant of the module

@nagyesta
Copy link
Contributor Author

nagyesta commented Sep 10, 2025

Hi Team,
just a friendly reminder about this PR. Could you please look at it and let me know whether it could be merged?
Thank you in advance!

mdelapenya
mdelapenya approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like @eddumelendez to take a look from the Java standpoint.

Other than that, LGTM, thanks for your contribution!

@nagyesta
Copy link
Contributor Author

nagyesta commented Sep 23, 2025

Hi @eddumelendez ,
please let me know in case you need anything for your review! Thank you!

@nagyesta
feat: Update Lowkey Vault module
0369be2 
- Set more specific category
- Add logo
- Add Java variant of the module

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta force-pushed the feat/update-lowkey-vault-module branch from b69e644 to 0369be2 Compare September 30, 2025 16:08
@nagyesta
Copy link
Contributor Author

nagyesta commented Sep 30, 2025

Hi @mdelapenya and @eddumelendez ,
I have rebased my changes, do we have a rough ETA regarding a review/merge please?

@nagyesta
Copy link
Contributor Author

nagyesta commented Oct 14, 2025

Hi @testcontainers/core-team,
this PR is open since 21 August. Is there any chance we could get it reviewed and merged soon?
Thank you in advance!

@mdelapenya mdelapenya merged commit 12ec1e4 into testcontainers:main Oct 22, 2025
1 check passed
@mdelapenya
Copy link
Member

mdelapenya commented Oct 22, 2025

Merged, thanks and sorry for the late response. We sometimes need to jump from project to project and may forget attending some PRs. But thanks for the ping 🙏

@nagyesta nagyesta deleted the feat/update-lowkey-vault-module branch October 22, 2025 11:51
@nagyesta
Copy link
Contributor Author

nagyesta commented Oct 22, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nagyesta @mdelapenya