Skip to content

fix: update destructured query names in presence query autofix#1365

Open
j1ang3 wants to merge 1 commit into
testing-library:mainfrom
j1ang3:fix-prefer-presence-queries-destructure-autofix
Open

fix: update destructured query names in presence query autofix#1365
j1ang3 wants to merge 1 commit into
testing-library:mainfrom
j1ang3:fix-prefer-presence-queries-destructure-autofix

Conversation

@j1ang3

@j1ang3 j1ang3 commented Jul 21, 2026

Copy link
Copy Markdown

Fixes #1359

Summary

  • update prefer-presence-queries autofixes to also rename safe destructured query bindings
  • avoid autofixing multi-reference destructured bindings where changing only one assertion would produce unsafe output
  • add regression coverage for presence, absence, and unsafe multi-reference destructured query cases

Tests

  • pnpm run lint
  • pnpm run type-check
  • vitest run tests/rules/prefer-presence-queries.test.ts --reporter=dot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prefer-presence-queries autofix leaves queryBy* in destructure while rewriting call site to getBy*, producing a ReferenceError

1 participant