infra[notask]: consolidate 13 on-pr-close-<pkg>.yml into on-pr-close.yml - #3733
Draft
sidj-thr wants to merge 1 commit into
Draft
infra[notask]: consolidate 13 on-pr-close-<pkg>.yml into on-pr-close.yml#3733sidj-thr wants to merge 1 commit into
sidj-thr wants to merge 1 commit into
Conversation
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
Contributor
Workflow security (shadow mode)zizmor found 1084 finding(s) in Findings are annotated inline on the changed files and listed in the job summary. Reproduce locally: pipx run zizmor==1.27.0 --offline .github/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on-pr-close-<pkg>.ymlfiles (ephemeral PR-version GPR cleanup onpull_request: closed) into oneon-pr-close.yml.public-delete-npm-versions.ymlalready loops a space-separatedpackageslist and auto-scopes topr-<n>from the event, and is a safe no-op for packages with no such version. Deletion is idempotent per package, so forcing nx-affected onto aclosed-PR event would add cost with no functional benefit.dry-run: trueforced onpull_requestevents (real deletes only via manual dispatch withdry-run: false),paths: packages/**scoping.on-pr-close-<pkg>.ymlfiles not deleted this pass.Test plan
actionlintclean (also validates the reusable-call input names againstpublic-delete-npm-versions.yml)act -nresolves and runs the reusable job graph on apull_requesteventpackageslist behaves as expected end-to-end🤖 Generated with Claude Code