Fix subquery over avg #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactor in thanos-io#477 introduces a bug where subquery on top of avg produces wrong results. This is because the parents are calculated before the query is rewritten, so the new nodes end up with no parents. Signed-off-by: Filip Petkovski <[email protected]>
fpetkovski
commented
Dec 3, 2024
| {name: "absent for existing metric", query: `absent(bar{pod="nginx-1"})`}, | ||
| {name: "absent for existing metric with aggregation", query: `sum(absent(bar{pod="nginx-1"}))`}, | ||
| {name: "subquery with sum/count", query: `max_over_time((sum(bar)/count(bar))[30s:15s])`}, | ||
| {name: "subquery with avg", query: `max_over_time(avg(bar)[30s:15s])`}, |
Collaborator
Author
There was a problem hiding this comment.
This test fails on main.
MichaHoffmann
approved these changes
Dec 3, 2024
Signed-off-by: Filip Petkovski <[email protected]>
3 tasks
subhramit
pushed a commit
to subhramit/promql-engine
that referenced
this pull request
Feb 12, 2025
* Fix subquery over avg The refactor in thanos-io#477 introduces a bug where subquery on top of avg produces wrong results. This is because the parents are calculated before the query is rewritten, so the new nodes end up with no parents. Signed-off-by: Filip Petkovski <[email protected]> * Fix lint Signed-off-by: Filip Petkovski <[email protected]> --------- Signed-off-by: Filip Petkovski <[email protected]> Signed-off-by: subhramit <[email protected]>
fpetkovski
added a commit
to fpetkovski/thanos
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor in #477 introduces a bug where subquery on top of avg produces wrong results.
This is because the parents are calculated before the query is rewritten, so the new nodes end up with no parents.