Fix distributed queries with explicit timestamp #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distributed optimizer does not consider queries with a specific timestamp which causes them to be incorrect for some cases. Signed-off-by: Filip Petkovski <[email protected]>
pedro-stanaka
approved these changes
Jan 20, 2025
Signed-off-by: Filip Petkovski <[email protected]>
fpetkovski
force-pushed
the
fix-distributed-timestamp
branch
from
b0575e5 to
e7ad926
Compare
Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
MichaHoffmann
approved these changes
Jan 21, 2025
SungJin1212
pushed a commit
to SungJin1212/promql-engine
that referenced
this pull request
Feb 3, 2025
* Fix distributed queries with explicit timestamp The distributed optimizer does not consider queries with a specific timestamp which causes them to be incorrect for some cases. Signed-off-by: Filip Petkovski <[email protected]> * Fallback when no match Signed-off-by: Filip Petkovski <[email protected]> * Fix tests Signed-off-by: Filip Petkovski <[email protected]> * Remove leftover Signed-off-by: Filip Petkovski <[email protected]> * Cover subqueries Signed-off-by: Filip Petkovski <[email protected]> * Remove field Signed-off-by: Filip Petkovski <[email protected]> * Add logical tests Signed-off-by: Filip Petkovski <[email protected]> --------- Signed-off-by: Filip Petkovski <[email protected]>
yeya24
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Fix distributed queries with explicit timestamp The distributed optimizer does not consider queries with a specific timestamp which causes them to be incorrect for some cases. Signed-off-by: Filip Petkovski <[email protected]> * Fallback when no match Signed-off-by: Filip Petkovski <[email protected]> * Fix tests Signed-off-by: Filip Petkovski <[email protected]> * Remove leftover Signed-off-by: Filip Petkovski <[email protected]> * Cover subqueries Signed-off-by: Filip Petkovski <[email protected]> * Remove field Signed-off-by: Filip Petkovski <[email protected]> * Add logical tests Signed-off-by: Filip Petkovski <[email protected]> --------- Signed-off-by: Filip Petkovski <[email protected]>
subhramit
pushed a commit
to subhramit/promql-engine
that referenced
this pull request
Feb 12, 2025
* Fix distributed queries with explicit timestamp The distributed optimizer does not consider queries with a specific timestamp which causes them to be incorrect for some cases. Signed-off-by: Filip Petkovski <[email protected]> * Fallback when no match Signed-off-by: Filip Petkovski <[email protected]> * Fix tests Signed-off-by: Filip Petkovski <[email protected]> * Remove leftover Signed-off-by: Filip Petkovski <[email protected]> * Cover subqueries Signed-off-by: Filip Petkovski <[email protected]> * Remove field Signed-off-by: Filip Petkovski <[email protected]> * Add logical tests Signed-off-by: Filip Petkovski <[email protected]> --------- Signed-off-by: Filip Petkovski <[email protected]> Signed-off-by: subhramit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distributed optimizer does not consider queries with a specific timestamp which causes them to be incorrect for some cases.
This commit adds a solution for this problem where such queries get distributed only to engines which have sufficient scope to cover its range.