Skip to content

Please review when possible - #31

Closed
CyberNexus-code wants to merge 2 commits into
the-csharp-academy:mainfrom
CyberNexus-code:main
Closed

Please review when possible#31
CyberNexus-code wants to merge 2 commits into
the-csharp-academy:mainfrom
CyberNexus-code:main

Conversation

@CyberNexus-code

Copy link
Copy Markdown

Hi, please review when possible.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

TheCSharpAcademy commented Sep 7, 2026

Copy link
Copy Markdown

@CyberNexus-code Project approved! 😄✅ It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later. Keep in mind that it's a very competitive environment out there in the software development industry. I highly recommend you do everything in your power to stand out from the competition. 👩‍🎤

Feedback
🔍️ When num2 is 0, writer.WriteValue("Divide") never executes:

case "/":
    if (num2 != 0)
    {
        result = num1 / num2;
        writer.WriteValue("Divide");
    }
    break;

The JSON writer has therefore received: "Operation": and is waiting for its value. Immediately afterwards the program calls:

writer.WritePropertyName("Result");

That can cause a JsonWriterException, because you're trying to start another property before supplying the value for "Operation".

🔍Your validation accepts double, so this message: "This is not valid input. Please enter an integer value:" should probably say numeric value rather than integer value, since values such as 2.5 are perfectly valid.

🔍I'd also change this:

if (Console.ReadKey().Key == ConsoleKey.Q)

because your instructions tell the user to press a key and Enter. ReadKey() only consumes the key, leaving the Enter keystroke waiting in the input stream when the user continues. On the following loop, the first Console.ReadLine() may therefore immediately receive an empty value.

🗺️ I noticed that the only course you've completed so far is Introduction to Object-Oriented Programming. I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive.😁

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants