This repository was archived by the owner on Apr 14, 2024. It is now read-only.
feat: Added Stream Functionality#20
Open
zymawy wants to merge 2 commits intothecodingmachine:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A similar PR may already be submitted!
Please search among the pull requests before creating one.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
Summary
I run into in satiation where I just want to stream the merged files directly to the client. instead of saving it or forcing the client to save the merged file into their machine. by this PR, I just added the functionality the make response serve as
streamed file
For more information, see the CONTRIBUTING guide.
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output.
Closing issues
Fixes #
Checklist
make lint)?make tests)?