Repository navigation
Fixes #39906 - Remove theforeman/* packages - #1077
Merged
Merged
Conversation
kmalyjur
self-requested a review
October 19, 2026 12:16
kmalyjur
requested changes
Oct 19, 2026
| module.exports = { | ||
| presets: ['@theforeman/builder/babel'], | ||
| presets: [ | ||
| require.resolve('@theforeman/builder/babel', { |
Contributor
There was a problem hiding this comment.
Isn't this still a usage of theforeman/* package? It could be using '../foreman/webpack/babel' instead.
EDIT: After a conversation with Lukshio, I agreed that '@theforeman/builder/babel' can stay
Member
There was a problem hiding this comment.
@Lukshio I tried testing it, and removed the file completely and it seems to work, could you explain why we should keep it and @theforeman/builder/babel ?
Contributor
Author
There was a problem hiding this comment.
@MariaAga I already updated the PR, forgot about removing it from core. I also added foreman version bump for all necessary repos.
kmalyjur
reviewed
Oct 19, 2026
Lukshio
force-pushed
the
removePackagesREX
branch
from
October 20, 2026 11:11
07c7353 to
a1a116c
Compare
pr-processor
Bot
added
Needs re-review
and removed
Waiting on contributor
Needs re-review
labels
Lukshio
force-pushed
the
removePackagesREX
branch
from
October 20, 2026 11:18
a1a116c to
9dcfc27
Compare
kmalyjur
approved these changes
Oct 21, 2026
kmalyjur
left a comment
kmalyjur
left a comment
Contributor
There was a problem hiding this comment.
Thank you, LGTM, I tested it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.