Allow explicitely killing process #101
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Watch tests are flaky because they spawn processes but they don't wait for those processes to finish. They eventually get cleaned up but in v4, they clean up after deno test finishes. Although, we didn't want to have an explicity kill on process to nudge people to rely on implicit cancellation, explicit
killis helpful in situations where you need to force kill as I do here.Approach
Add a kill function to process.