This repository was archived by the owner on Jun 9, 2026. It is now read-only.
chore(deps): bump typescript to ^5.9 (monorepo prep) - #189
Merged
Merged
Conversation
Bump typescript from ^5.8.2 to ^5.9.3. This requires @typescript-eslint to move from 8.27.0 to 8.60.1 in the lockfile, because 8.27.0's peer range is `typescript >=4.8.4 <5.9.0` (excludes 5.9) while 8.60.1 allows `<6.1.0`; both satisfy the existing `^8` ranges, so no package.json range changes are needed. `nest build` (tsc) reports 0 issues and `npm run lint` passes with no bump-induced errors. Monorepo prep: dependency normalization ahead of the omni monorepo migration. Co-authored-by: Cursor <cursoragent@cursor.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![delegate-reviewer[bot]](https://avatars.githubusercontent.com/in/3615711?s=60&v=4){kind=small}
The umbrella `typescript-eslint` package stayed pinned at 8.27.0 in the lockfile (peer `typescript >=4.8.4 <5.9.0`), which conflicts with the typescript 5.9.3 bump and breaks strict `npm ci` (ERESOLVE). Bump the specifier to ^8.60.0 so npm resolves the umbrella to 8.60.1 (peer `<6.1.0`), matching the already-resolved @typescript-eslint/* packages. Addresses delegate review blocker on #189. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Fixed in ea05dda: bumped the delegate review |
Resolve package-lock.json conflict (siblings #187/#188/#190 merged to develop and moved package.json/package-lock.json). package.json auto-merged cleanly, preserving this PR's typescript ^5.9.3 + typescript-eslint ^8.60.0 alongside develop's changes. Lockfile regenerated via npm install (umbrella typescript-eslint -> 8.60.1) so it matches the merged package.json; strict npm ci resolves with no ERESOLVE, build + lint green. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Merged latest
delegate review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monorepo prep
Dependency normalization ahead of the omni monorepo migration.
What
typescriptfrom^5.8.2to^5.9.3inpackage.json.@typescript-eslint/*moves from 8.27.0 → 8.60.1 (plus a few of its transitive deps). This is required, not scope creep:@typescript-eslint8.27.0 declares the peer rangetypescript >=4.8.4 <5.9.0(excludes 5.9), while 8.60.1 allows<6.1.0. Both satisfy the existing^8/^8.27.0ranges already inpackage.json, so no dependency-range edits are needed.Validation
npx tsc --version→ 5.9.3.npm run build✅ —nest build(tsc) reports 0 issues.npm run lint✅ — passes with no bump-induced errors (pre-existing prettier auto-fixes were not included; onlypackage.json/package-lock.jsonchanged).Made with Cursor
Note
Low Risk
Dev-only compiler and lint toolchain updates with no runtime or application code changes; validate via existing build/lint.
Overview
Monorepo prep: bumps the dev dependency TypeScript from
^5.8.2to^5.9.3inpackage.json, with the lockfile resolving 5.9.3.The lockfile also pulls
@typescript-eslint/*from 8.27.0 → 8.60.1 (and related transitive updates) so ESLint tooling matches TypeScript 5.9—8.27’s peer range caps TypeScript below 5.9, while 8.60.x allows up to 6.1.typescript-eslintinpackage.jsonis unchanged (^8.27.0); no application source files are modified.Reviewed by Cursor Bugbot for commit df449cf. Configure here.