Skip to content

✨ Add focus ring to legacy buttons to match v4 #2995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b-l-i-n-d merged 1 commit into from
Sep 9, 2026
+30 −3
Merged

✨ Add focus ring to legacy buttons to match v4 #2995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions classes/Options_V2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1466,7 +1466,7 @@ public function get_setting_fields() {
'key' => 'page_elements',
'type' => 'toggle_matrix',
'label' => __( 'Header & Footer', 'tutor' ),
'desc' => __( 'Control the visibility of Header and Footer for Dashboard and Learning Experience', 'tutor' ),
'desc' => __( 'Control the visibility of Header and Footer for Dashboard and Learning Area', 'tutor' ),
'columns' => array(
'header' => array(
'label' => __( 'Header', 'tutor' ),
Expand All @@ -1491,7 +1491,7 @@ public function get_setting_fields() {
),
),
'learning' => array(
'label' => __( 'Learning Experience', 'tutor' ),
'label' => __( 'Learning Area', 'tutor' ),
'header' => array(
'key' => 'show_learning_site_header',
'default' => $default_visibility,
Expand Down
29 changes: 28 additions & 1 deletion v2-library/src/scss/elements/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
$disabled-color: #e9e9ea !default;

button.tutor-btn,
a.tutor-btn,
.tutor-btn {
&:focus,
&:focus-visible {
&:not(:disabled):not([disabled]):not(.disabled) {
outline: none;
box-shadow: 0px 0px 0px 2px var(--tutor-brand-450, #90A0F7);
}
}
}

.tutor-btn {
display: inline-flex;
align-items: center;
Expand All @@ -17,7 +29,15 @@ $disabled-color: #e9e9ea !default;
border-radius: 6px;
box-sizing: border-box;
cursor: pointer;
transition: color 200ms ease-in-out, background-color 200ms ease-in-out, border-color 200ms ease-in-out;
transition: color 200ms ease-in-out, background-color 200ms ease-in-out, border-color 200ms ease-in-out, box-shadow 200ms ease-in-out;

&:focus,
&:focus-visible {
&:not(:disabled):not([disabled]):not(.disabled) {
outline: none;
box-shadow: 0px 0px 0px 2px var(--tutor-brand-450, #90A0F7);
}
}

&[disabled],
&.disabled {
Expand Down Expand Up @@ -392,10 +412,17 @@ $disabled-color: #e9e9ea !default;
display: inline-flex;
vertical-align: middle;

button.tutor-btn,
a.tutor-btn,
.tutor-btn {
position: relative;
flex: 1;

&:focus,
&:focus-visible {
z-index: 1;
}

&:not(:last-child) {
border-top-right-radius: 0;
border-bottom-right-radius: 0;
Expand Down
Loading