Repository navigation
Fix offline ISO GitHub CI builder source download - #36
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The target branch and required scripts exist, and the sparse checkout preserves all files needed by the ISO builder.
0 open findings
What changed in this PR
Updates the offline ISO builder to reliably fetch Alpine’s aports sources in GitHub CI.
Changes:
- Switches aports cloning to the official GitHub mirror.
- Uses partial clone and sparse checkout for the required
scriptsdirectory.
| File | Description |
|---|---|
scripts/build-vm-iso-inner.sh |
Updates and optimizes the Alpine aports checkout. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first merged ISO pipeline run failed because
gitlab.alpinelinux.orgreturned HTTP 418 on GitHub-hosted runners during thebuild-isojob. Switch to the officialgithub.com/alpinelinux/aportsmirror, still using the Alpine 3.22-stable branch. Sparse-checkout only the image-buildingscriptsdirectory to reduce checkout size and improve reliability. Previously built 124 MB offline ISO succeeded in local Alpine mkimage, checksum, BIOS QEMU boot, embedded LiteEdge, and 143 package offline resolution tests. Re-run the full workflow after this fix.