Skip to content

Conversation

@crazoes
Copy link

@crazoes crazoes commented Jul 26, 2020

Add implementation for MU write in order to
communicate with the host.

Signed-off-by: Diana Cretu [email protected]
Signed-off-by: Shreeya Patel [email protected]

@crazoes
Copy link
Author

crazoes commented Jul 26, 2020

This extends the work that was being done here earlier - #40

@dbaluta
Copy link

dbaluta commented Jul 27, 2020

@crazoes please squash this PR with #40. Thus you will have one big commit with patches squashed. The explanation in this commit is very good, you can keep it at the end of the commit for the squashed commits.

By squash I mean this: https://www.devroom.io/2011/07/05/git-squash-your-latests-commits-into-one/

@crazoes
Copy link
Author

crazoes commented Jul 27, 2020

@dbaluta it is already squashed with that PR's commits

@dbaluta
Copy link

dbaluta commented Jul 27, 2020

@crazoes Indeed, you are right! thanks!

Add implementation for MU write in order to communicate with the host.
We add and store reference to both side A and side B's MUs in the adsp
structure because write to control register of side B has to make and
reflect some changes in status register of side A.

Signed-off-by: Diana Cretu <[email protected]>
Signed-off-by: Shreeya Patel <[email protected]>
@dbaluta
Copy link

dbaluta commented Jul 27, 2020

LGTM, @lgirdwood this is good to merge.

@lgirdwood lgirdwood merged commit f71c955 into thesofproject:sof-v4.2 Aug 3, 2020
@marc-hb
Copy link

marc-hb commented May 13, 2021

For some reason this is not compatible with Ubuntu 20.04? See thesofproject/sof#4186

@fredoh9
Copy link

fredoh9 commented May 14, 2021

This is not working either Ubuntu 18.04 or 20.04. We haven't made sofqemu image for a year. This is first time image update after this commit.

@marc-hb
Copy link

marc-hb commented May 14, 2021

Thanks @fredoh9 , sorry for the confusion.

So this commit is the last commit in qemu:master. @fredoh9 how long would it take to upgrade sofqemu to Ubuntu 20.04 and qemu:master~1?

@fredoh9
Copy link

fredoh9 commented May 14, 2021

Building sofeqmu is faster then sof image. In my build machine, it takes about 10 min.

@marc-hb
Copy link

marc-hb commented May 14, 2021

Hi @fred, I was asking how much effort it would be for you, sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants