schedule: remove scheduler_restore()#10833
Open
kv2019i wants to merge 1 commit into
Open
Conversation
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the (now-unused) scheduler “restore” hook from the schedule.h public scheduling interface, aligning the header with the ongoing shift of low-level task scheduling to Zephyr and keeping SOF’s scheduling API focused on audio task scheduling.
Changes:
- Dropped
scheduler_ops::scheduler_restorefromstruct scheduler_ops. - Removed the
schedulers_restore()inline wrapper that iterated over registered schedulers.
Comment on lines
143
to
152
| /** | ||
| * Frees scheduler's resources. | ||
| * @param data Private data of selected scheduler. | ||
| * @param flags Function specific flags. | ||
| * @return 0 if succeeded, error code otherwise. | ||
| * | ||
| * This operation is optional. | ||
| */ | ||
| void (*scheduler_free)(void *data, uint32_t flags); | ||
|
|
||
| /** | ||
| * Restores scheduler's resources. | ||
| * @param data Private data of selected scheduler. | ||
| * @return 0 if succeeded, error code otherwise. | ||
| * | ||
| * This operation is optional. | ||
| */ | ||
| int (*scheduler_restore)(void *data); | ||
| }; |
Comment on lines
143
to
152
| /** | ||
| * Frees scheduler's resources. | ||
| * @param data Private data of selected scheduler. | ||
| * @param flags Function specific flags. | ||
| * @return 0 if succeeded, error code otherwise. | ||
| * | ||
| * This operation is optional. | ||
| */ | ||
| void (*scheduler_free)(void *data, uint32_t flags); | ||
|
|
||
| /** | ||
| * Restores scheduler's resources. | ||
| * @param data Private data of selected scheduler. | ||
| * @return 0 if succeeded, error code otherwise. | ||
| * | ||
| * This operation is optional. | ||
| */ | ||
| int (*scheduler_restore)(void *data); | ||
| }; |
Collaborator
|
one more sof/src/schedule/ll_schedule_xtos.c Line 811 in 442aa07 |
kv2019i
force-pushed
the
202606-sched-changes
branch
from
442aa07 to
3150381
Compare
kv2019i
requested review from
LaurentiuM1234,
marcinszkudlinski and
pblaszko
as code owners
Collaborator
Author
|
V2 pushed:
|
lyakh
approved these changes
Jun 2, 2026
The last user of scheduler_restore() was removed in commit 4f2e381 ("build: remove more XTOS left-overs"), so we can proceed it to remove it from schedule.h interface. This will pave way for further simplications of the schedule.h interface now as the role of this interface is reduce to audio task scheduling, while low-level task scheduling is done in Zephyr. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202606-sched-changes
branch
from
3150381 to
28c3232
Compare
Collaborator
Author
|
V3 pushed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last user of schedule_restore() was removed in commit 4f2e381 ("build: remove more XTOS left-overs"), so we can proceed it to remove it from schedule.h interface.
This will pave way for further simplications of the schedule.h interface now as the role of this interface is reduce to audio task scheduling, while low-level task scheduling is done in Zephyr.