fix: on-policy distillation missing temperature parameter fix #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quires a temperature parameter, right now it is not specified so the run will fail. Added this parameter for distillation/train_on_policy.py and the recipes
Collaborator
|
@claude please merge in main then review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
joschu
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The do_group_rollout_and_filter_constant_reward sampling step requires a temperature parameter, right now it is not specified in
distillation/train_on_policy.pyso the runs will fail. Added thetemperatureparameter to config and specifying it in do_group_rollout_and_filter_constant_reward fordistillation/train_on_policy.pyand the recipes fixes the problem.