Skip to content

Conversation

@joschu
Copy link
Collaborator

@joschu joschu commented Nov 23, 2025

The verifiers package underwent breaking API changes in v0.1.8:

  • GenerateOutputs changed from a class to TypedDict, requiring bracket notation
  • rollout() now takes RolloutInput dict instead of individual parameters
  • score_rollout() signature changed to (state, score_sem) only

Changes:

  • evaluate.py: Use bracket notation for GenerateOutputs fields
  • train.py: Update rollout() to use RolloutInput dict structure
  • train.py: Update score_rollout() to new signature with score_sem
  • train.py: Extract reward/metrics from state after scoring

🤖 Generated with Claude Code

The verifiers package underwent breaking API changes in v0.1.8:
- GenerateOutputs changed from a class to TypedDict, requiring bracket notation
- rollout() now takes RolloutInput dict instead of individual parameters
- score_rollout() signature changed to (state, score_sem) only

Changes:
- evaluate.py: Use bracket notation for GenerateOutputs fields
- train.py: Update rollout() to use RolloutInput dict structure
- train.py: Update score_rollout() to new signature with score_sem
- train.py: Extract reward/metrics from state after scoring

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@joschu joschu requested a review from willccbb November 23, 2025 01:34
@joschu joschu marked this pull request as ready for review November 23, 2025 02:27
@joschu
Copy link
Collaborator Author

joschu commented Nov 23, 2025

I wasn't able to test that it actually works due to other installation issues

Copy link

@LiyuanLucasLiu LiyuanLucasLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp!

Copy link

@LiyuanLucasLiu LiyuanLucasLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp!

@joschu
Copy link
Collaborator Author

joschu commented Nov 23, 2025

OK I was able to get it running on reverse-text. I'm going to merge for now because this is breaking our CI, and if there are still issues, we can fix them based on @willccbb's input.

@joschu joschu merged commit 5539488 into main Nov 23, 2025
2 checks passed
@willccbb
Copy link
Contributor

ah sorry yes feel free to merge! had started on a patch but got pulled away--will test tomorrow and put up any other changes needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants