Skip to content

Enable MSBuild node reuse on Windows and macOS - #3582

Open
thomhurst wants to merge 1 commit into
mainfrom
issue-3452-msbuild-node-reuse
Open

Enable MSBuild node reuse on Windows and macOS#3582
thomhurst wants to merge 1 commit into
mainfrom
issue-3452-msbuild-node-reuse

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

  • keep MSBuild node reuse enabled for Windows and macOS compile-only jobs
  • retain MSBUILDDISABLENODEREUSE=1 on Ubuntu jobs that use it for memory control

Validation

  • workflow diff and whitespace checked
  • actionlint was unavailable locally; GitHub Actions will validate workflow syntax

Closes #3452

@thomhurst

Copy link
Copy Markdown
Owner Author

Ready for review. This removes MSBUILDDISABLENODEREUSE only from the Windows/macOS cross-platform build matrix; Ubuntu analyzer, pipeline, and trim/AOT memory controls remain intact. @codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: c87011ca7e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: scope MSBUILDDISABLENODEREUSE to the ubuntu pipeline job - 3-4x duration variance on windows/macos compile jobs

1 participant