Skip to content

[pull] master from apify:master #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Feb 24, 2026
Merged

[pull] master from apify:master #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/browser-pool/src/puppeteer/puppeteer-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ export class PuppeteerPlugin extends BrowserPlugin<
'version',
'on',
'process',
'pages',
] as const
).reduce((map, method) => {
map[method] = browser[method as 'close']?.bind(browser);
Expand Down
12 changes: 12 additions & 0 deletions test/browser-pool/browser-plugins/plugins.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,18 @@ describe('Plugins', () => {
}
});

test.concurrent('should allow calling functions on the proxied browser', async () => {
const plugin = new PuppeteerPlugin(puppeteer);
const launchContext = plugin.createLaunchContext();
const browser = await plugin.launch(launchContext);

try {
await expect(browser.pages()).resolves.toBeDefined();
} finally {
await browser.close();
}
});

test.concurrent('should pass launch options to browser', async () => {
const plugin = new PuppeteerPlugin(puppeteer);

Expand Down
Loading