MinPlatformPkg/TestPointCheckLib: Fix method declarations #914
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On building packages which include debug library TestPointCheckLib in GCC5 we encounter the following non-fatal warnings (abbreviated): TestPointCheckLib/DxeTestPointCheckLib.c:142:1: warning: type of ‘TestPointCheckTcgMor’ does not match original declaration [-Wlto-type-mismatch] TestPointCheckLib/DxeCheckTcgMor.c:31:1: note: ‘TestPointCheckTcgMor’ was previously declared here TestPointCheckLib/DxeTestPointCheckLib.c:137:1: warning: type of ‘TestPointCheckTcgTrustedBoot’ does not match original declaration [-Wlto-type-mismatch] TestPointCheckLib/DxeCheckTcgTrustedBoot.c:28:1: note: ‘TestPointCheckTcgTrustedBoot’ was previously declared here TestPointCheckLib/DxeTestPointCheckLib.c:132:1: warning: type of ‘TestPointCheckPiSignedFvBoot’ does not match original declaration [-Wlto-type-mismatch] TestPointCheckLib/DxeCheckPiSignedFvBoot.c:19:1: note: ‘TestPointCheckPiSignedFvBoot’ was previously declared here TestPointCheckLib/DxeTestPointCheckLib.c:127:1: warning: type of ‘TestPointCheckUefiSecureBoot’ does not match original declaration [-Wlto-type-mismatch] TestPointCheckLib/DxeCheckUefiSecureBoot.c:40:1: note: ‘TestPointCheckUefiSecureBoot’ was previously declared here Fix this by adding EFIAPI to method declarations which don't have it when their definitions do, in DxeTestPointCheckLib.c. Signed-off-by: Mike Beaton <[email protected]>
mikebeaton
requested review from
ChaselChiu,
SaiChaganty and
nate-desimone
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On building packages which include debug library TestPointCheckLib in GCC5 we encounter the following non-fatal warnings (abbreviated):
TestPointCheckLib/DxeTestPointCheckLib.c:142:1: warning: type of ‘TestPointCheckTcgMor’ does not match original declaration [-Wlto-type-mismatch]
TestPointCheckLib/DxeCheckTcgMor.c:31:1: note: ‘TestPointCheckTcgMor’ was previously declared here
TestPointCheckLib/DxeTestPointCheckLib.c:137:1: warning: type of ‘TestPointCheckTcgTrustedBoot’ does not match original declaration [-Wlto-type-mismatch]
TestPointCheckLib/DxeCheckTcgTrustedBoot.c:28:1: note: ‘TestPointCheckTcgTrustedBoot’ was previously declared here
TestPointCheckLib/DxeTestPointCheckLib.c:132:1: warning: type of ‘TestPointCheckPiSignedFvBoot’ does not match original declaration [-Wlto-type-mismatch]
TestPointCheckLib/DxeCheckPiSignedFvBoot.c:19:1: note: ‘TestPointCheckPiSignedFvBoot’ was previously declared here
TestPointCheckLib/DxeTestPointCheckLib.c:127:1: warning: type of ‘TestPointCheckUefiSecureBoot’ does not match original declaration [-Wlto-type-mismatch]
TestPointCheckLib/DxeCheckUefiSecureBoot.c:40:1: note: ‘TestPointCheckUefiSecureBoot’ was previously declared here
Fix this by adding EFIAPI to method declarations which don't have it when their definitions do, in DxeTestPointCheckLib.c.