Fixes for gcc 15 / C23 #11720
Open
Fixes for gcc 15 / C23 #11720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 15 enforces stricter type checking for function pointers. When passing SPDM transport layer callbacks to libspdm_register_transport_layer_func, the function pointer types are incompatible due to differences in boolean parameter types. The EDK2 uses BOOLEAN (UINT8) while libspdm uses C99 bool (_Bool). Although these types have the same size and representation, GCC 15 treats them as incompatible. Add explicit casts to libspdm_transport_encode_message_func and libspdm_transport_decode_message_func at the call site to resolve the type mismatch. This is safe as the types have identical binary representation and the functions are only called through these pointers by libspdm. Signed-off-by: Oliver Steffen <[email protected]>
GCC 15 enforces stricter type checking for function pointers. When passing EFI_PERIODIC_CALLBACK and EFI_EXCEPTION_CALLBACK to ManageIdtEntryTable, explicit casts to CALLBACK_FUNC are required to avoid incompatible pointer type errors. Add explicit casts at the call sites in RegisterPeriodicCallback and RegisterExceptionCallback functions. Signed-off-by: Oliver Steffen <[email protected]>
luigix25
reviewed
Nov 6, 2025
jyao1
approved these changes
Nov 13, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small fixes to allow building with GCC15 which defaults to C23 standard,
which has stricter warnings on type casts.
This is needed to use the new Fedora 43 images in the CI (for the Linux) builds.
How This Was Tested
Running builds locally.
Integration Instructions