Skip to content

MdeModulePkg/AcpiTableDxe:Fixed exception when enable SpecialPool #11736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2025
Merged

MdeModulePkg/AcpiTableDxe:Fixed exception when enable SpecialPool #11736

merged 1 commit into from
Nov 23, 2025
+58 −37

Conversation

@GeorgeLiao012
Copy link
Contributor

@GeorgeLiao012 GeorgeLiao012 commented Nov 10, 2025 •
edited
Loading

Description

In some corner cases the NeedToInstallTable not been initialized
in the InstallAcpiTableFromAcpiSiliconHob (), which caused memory
exception by enable special pool function.

This patch initialized NeedToInstallTable in any conidiation during
InstallAcpiTableFromAcpiSiliconHob ().

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

SUT boots to operation system with below conidiations

  1. Without install DSDT or FACS during the PEI phase.
  2. Build BIOS with enable SpecialPool

Integration Instructions

None

@tianocore-pr-automation
Copy link

tianocore-pr-automation bot commented Nov 10, 2025

Pull Request Formatting Issues

⚠️ Remove the following template lines from your PR description:
<_Include a description of the change and why this change was made._>
<_For each item, place an "x" in between [and]if true. Example:[x] (you can also check items in GitHub UI)_>
<_Create the PR as a Draft PR if it is only created to run CI checks._>
<_Delete lines in \<\> tags before creating the PR._>

Address these issues and the validation will automatically re-run when you update your pull request.

@GeorgeLiao012 GeorgeLiao012 force-pushed the Fixed_exception_when_SpecialPool_enable branch 2 times, most recently from b3d5b38 to 11029f6 Compare November 10, 2025 15:24
@GeorgeLiao012
Copy link
Contributor Author

GeorgeLiao012 commented Nov 10, 2025

Hi @mdkinney @ankit13s
Could you please review this PR? Thank you.

@GeorgeLiao012 GeorgeLiao012 force-pushed the Fixed_exception_when_SpecialPool_enable branch from 11029f6 to e44fec6 Compare November 10, 2025 17:33
mdkinney
mdkinney reviewed Nov 13, 2025
View reviewed changes
@GeorgeLiao012 GeorgeLiao012 force-pushed the Fixed_exception_when_SpecialPool_enable branch from e44fec6 to 462d9a3 Compare November 13, 2025 08:10
@GeorgeLiao012
Copy link
Contributor Author

GeorgeLiao012 commented Nov 14, 2025

@lgao4 @ankit13s
Could you review this PR? Thanks.

mdkinney
mdkinney reviewed Nov 14, 2025
View reviewed changes
@GeorgeLiao012 GeorgeLiao012 force-pushed the Fixed_exception_when_SpecialPool_enable branch 2 times, most recently from b67e237 to 129e6e5 Compare November 17, 2025 09:07
@GeorgeLiao012
Copy link
Contributor Author

GeorgeLiao012 commented Nov 21, 2025

@ankit13s @lgao4 @mdkinney
Could you review PR again? If it is OK to you, could you approve it? then this PR can be merged.

@ardbiesheuvel ardbiesheuvel added the push Auto push patch series in PR if all checks pass label Nov 22, 2025
@tianocore-assign-reviewers
Copy link

tianocore-assign-reviewers bot commented Nov 23, 2025

⚠ WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future.

Non-collaborators requested:

Attn Admins:

Admin Instructions:

  • Add the non-collaborators as collaborators to the appropriate team(s) listed in teams
  • If they are no longer needed as reviewers, remove them from Maintainers.txt

@ardbiesheuvel ardbiesheuvel force-pushed the Fixed_exception_when_SpecialPool_enable branch from 2d93ff7 to 129e6e5 Compare November 23, 2025 11:01
@GeorgeLiao012 @ardbiesheuvel
MdeModulePkg/AcpiTableDxe: Fixed exception when enable SpecialPool
b39fb99 
In some corner cases the NeedToInstallTable not been initialized
well in the InstallAcpiTableFromAcpiSiliconHob, which caused
exception when enable special pool function.

This patch fixed exception by initialize NeedToInstallTable
well.

Signed-off-by: George Liao <[email protected]>
@ardbiesheuvel ardbiesheuvel force-pushed the Fixed_exception_when_SpecialPool_enable branch from 129e6e5 to b39fb99 Compare November 23, 2025 11:02
@mergify mergify bot added the queued label Nov 23, 2025
@mergify mergify bot merged commit 30b405d into tianocore:master Nov 23, 2025
115 of 116 checks passed
@mergify mergify bot removed the queued label Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdkinney mdkinney mdkinney left review comments

@lgao4 lgao4 lgao4 approved these changes

@dandanbi dandanbi Awaiting requested review from dandanbi

@LiuZhiguang001 LiuZhiguang001 Awaiting requested review from LiuZhiguang001

+1 more reviewer

@ankit13s ankit13s ankit13s approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

push Auto push patch series in PR if all checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GeorgeLiao012 @lgao4 @mdkinney @ankit13s @ardbiesheuvel