BaseTools: Update brotli submodule #11745
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the brotli submodule to the commit (e230f474).
to avoid build failures in the IA64/LoongArch architecture's
native compiler.
The fundamental reason is that GCC does not support the
__attribute__((model("small"))).
REF:google/brotli#1369
Suggested-by: MingcongBai <[email protected]>
Signed-off-by: Dongyan Qian <[email protected]>
tianocore-assign-reviewers
bot
requested review from
YuweiChen1110,
gapalomi,
lgao4 and
ponchofigueroa
Member
Author
|
@vineelko The upstream brotli had an issue google/brotli#1368 where the LoongArch/IA64 native architecture fails to build.. It has been merged google/brotli@e230f47 and needs to be synchronized. Please review. |
vineelko
approved these changes
Nov 13, 2025
Contributor
Is MdeModulePkg Brotli Decompression Lib requried to be udpated? |
Member
Author
You are right, I will add and verify it immediately, thank you. |
Update the brotli submodule to the commit (e230f474).
to avoid build failures in the IA64/LoongArch architecture's
native compiler.
The fundamental reason is that GCC does not support the
__attribute__((model("small"))).
REF:google/brotli#1369
Signed-off-by: Dongyan Qian <[email protected]>
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the brotli submodule to the commit (e230f474). to avoid build failures in the IA64/LoongArch architecture's native compiler.
The fundamental reason is that GCC does not support the attribute((model("small"))).
REF:google/brotli#1369
Suggested-by: MingcongBai [email protected]
Signed-off-by: Dongyan Qian [email protected]
How This Was Tested
build in the LoongArch architecture or IA64 using native compiler.