-
Notifications
You must be signed in to change notification settings - Fork 3k
IntelFsp2Pkg/Tools/ConfigEditor: Fixed data difference issue #11753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Formatting Issues
Address these issues and the validation will automatically re-run when you update your pull request. |
86920f4 to
3bd9185
Compare
Pull Request Formatting Issues
Address these issues and the validation will automatically re-run when you update your pull request. |
fb74cf1 to
1173013
Compare
Problem Description: load_default_from_bin caused data difference errors when loading fsp.bsf and fsp.fd, due to multiple identical UPD signatures. The original string search picked the first match, which could be the wrong region. Solution Description: Updated GenYamlCfg.py to locate UPD data by FFS GUID FSP_T, FSP_M, FSP_S_UPD_FFS_GUID before searching UPD signatures. This ensures correct region matching and retains the old string search as a fallback. Signed-off-by: Hsu JasonX <[email protected]>
1173013 to
7b7cef1
Compare
Description
Problem Description:
load_default_from_bin() caused data difference
errors when loading fsp.bsf and fsp.fd,
due to multiple identical UPD signatures.
The original string search picked the first match, which could be the wrong region
Solution Implementation:
Updated GenYamlCfg.py to locate UPD data
by FFS GUID (FSP_T/M/S_UPD_FFS_GUID)
before searching UPD signatures.
This ensures correct region matching
and retains the old string search as a fallback.
How This Was Tested
Run the ConfigEditor tool with the actual fsp.bsf and fsp.fd files for validation.
Integration Instructions
None