Skip to content

Conversation

@yunhsiax
Copy link
Contributor

@yunhsiax yunhsiax commented Nov 13, 2025

Description

Problem Description:
load_default_from_bin() caused data difference
errors when loading fsp.bsf and fsp.fd,
due to multiple identical UPD signatures.
The original string search picked the first match, which could be the wrong region

Solution Implementation:
Updated GenYamlCfg.py to locate UPD data
by FFS GUID (FSP_T/M/S_UPD_FFS_GUID)
before searching UPD signatures.
This ensures correct region matching
and retains the old string search as a fallback.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?

How This Was Tested

Run the ConfigEditor tool with the actual fsp.bsf and fsp.fd files for validation.

Integration Instructions

None

@tianocore-pr-automation
Copy link

Pull Request Formatting Issues

⚠️ Remove the following template lines from your PR description:
<_Include a description of the change and why this change was made._>
<_For each item, place an "x" in between [and]if true. Example:[x] (you can also check items in GitHub UI)_>
<_Create the PR as a Draft PR if it is only created to run CI checks._>
<_Delete lines in \<\> tags before creating the PR._>
<_Describe the test(s) that were run to verify the changes._>
<_Describe how these changes should be integrated. Use N/A if nothing is required._>

Address these issues and the validation will automatically re-run when you update your pull request.

@yunhsiax yunhsiax force-pushed the Fix-data-difference-issue branch 2 times, most recently from 86920f4 to 3bd9185 Compare November 14, 2025 06:13
@tianocore-pr-automation
Copy link

Pull Request Formatting Issues

⚠️ Remove the following template lines from your PR description:
<_Describe the test(s) that were run to verify the changes._>
<_Describe how these changes should be integrated. Use N/A if nothing is required._>

Address these issues and the validation will automatically re-run when you update your pull request.

@yunhsiax yunhsiax force-pushed the Fix-data-difference-issue branch 3 times, most recently from fb74cf1 to 1173013 Compare November 20, 2025 05:50
Problem Description:
load_default_from_bin caused data difference
errors when loading fsp.bsf and fsp.fd,
due to multiple identical UPD signatures.
The original string search picked the first match,
which could be the wrong region.

Solution Description:
Updated GenYamlCfg.py to locate UPD data
by FFS GUID FSP_T, FSP_M, FSP_S_UPD_FFS_GUID
before searching UPD signatures.
This ensures correct region matching
and retains the old string search as a fallback.

Signed-off-by: Hsu JasonX <[email protected]>
@yunhsiax yunhsiax force-pushed the Fix-data-difference-issue branch from 1173013 to 7b7cef1 Compare November 20, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants