use parens to prevent exceptions with newer helm binaries #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer version of the helm cli (e.g. v3.19.2) would error on these expressions if the Values.deployment wasn't set. Previous versions of the helm cli (e.g. 3.12.3) did *not* exhibit this behavior. These changes are tested with both 3.19.2 and 3.12.3 and seem to work fine for both. Thanks to Clint for point this out.
Contributor
Author
|
Well, this wasn't enough to fix all the problems, we also have to deal with: So until we can dedicate a bit more time to analyzing this and fixing it, it might be best to just say, "use an older version of helm". |
|
@ewollesen hello. What is the error with the max file/chart size ? On which location ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of the helm cli (e.g. v3.19.2) would error on these
expressions if the Values.deployment wasn't set.
Previous versions of the helm cli (e.g. 3.12.3) did not exhibit this
behavior.
These changes are tested with both 3.19.2 and 3.12.3 and seem to work
fine for both.
Thanks to Clint for point this out.