storage: Add APIs for RawKV GC #4937
Conversation
Signed-off-by: AmoebaProtozoa <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
the
release-note
|
/cc @nolouch @AndreMouche |
Signed-off-by: AmoebaProtozoa <[email protected]>
Signed-off-by: AmoebaProtozoa <[email protected]>
Signed-off-by: AmoebaProtozoa <[email protected]>
Signed-off-by: AmoebaProtozoa <[email protected]>
Signed-off-by: AmoebaProtozoa <[email protected]>
Signed-off-by: David <[email protected]>
|
@pingyu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
| } | ||
|
|
||
| // KeySpaceServiceSafePointPath returns the path of given service's service safe point. | ||
| // Path: /key_space/gc_safepoint/{space_id}/service/{service_id} |
There was a problem hiding this comment.
Can we know the endpoint types from service_id? such as it's from tidb, raw_kv client, cdc or others?
There was a problem hiding this comment.
I don't think we can tell by service_id alone,
for example, both TiDB and raw_kv's gc_worker may use gc_worker as their service_id
There was a problem hiding this comment.
So... Is it different in space_id? like cdc_xxx, tidb_xxx, client_xxxx . I would like to know who use the path.
There was a problem hiding this comment.
currently, we use spaceID to differentiate key spaces, things like
default_rawkv, default_txnkv, default_tidb
serviceID is used to identify the specific service under that KeySpace, like
cdc, br, etc.
tidb cdc and rawkv cdc may have the same serviceID but different spaceIDs
rawkv cdc and rawkv br have the same spaceID but different serviceIDs
Codecov Report
@@ Coverage Diff @@
## master #4937 +/- ##
==========================================
- Coverage 75.57% 75.43% -0.14%
==========================================
Files 307 308 +1
Lines 30201 30281 +80
==========================================
+ Hits 22823 22842 +19
- Misses 5396 5453 +57
- Partials 1982 1986 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nolouch
left a comment
nolouch
left a comment
There was a problem hiding this comment.
LGTM. better merge it to master after release-6.1 checkout.
Signed-off-by: David <[email protected]>
|
Could we merge this PR? |
|
We can merge it now, cc @AndreMouche |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 769a40b
|
ti-chi-bot
added
the
status/can-merge
6 participants
Signed-off-by: AmoebaProtozoa [email protected]
What problem does this PR solve?
Add APIs for RawKV GC (storage part of #4866).
Issue Number: ref #4865
RFC: tikv/rfcs#90
What is changed and how does it work?
Check List
Tests
Code changes
No
No
No
Side effects
No
Release note