-
Notifications
You must be signed in to change notification settings - Fork 747
client: updating keyspace group must check the previous version #9862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2f5525f to
1460ce5
Compare
Signed-off-by: 童剑 <[email protected]>
1460ce5 to
3f7b9ee
Compare
Signed-off-by: 童剑 <[email protected]>
Signed-off-by: 童剑 <[email protected]>
Signed-off-by: 童剑 <[email protected]>
Signed-off-by: 童剑 <[email protected]>
Signed-off-by: 童剑 <[email protected]>
d34bbed to
a05cff6
Compare
|
@bufferflies: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // urls are the primary/secondary serving URL | ||
| urls []string | ||
|
|
||
| // version is used to avoid updating stale info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a comment to clarify where the version is sourced from and briefly explain its usage?
| primaryURL: "", | ||
| secondaryURLs: make([]string, 0), | ||
| urls: make([]string, 0), | ||
| version: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the TSO client starts up, does it use version=0 for the initial request?
Furthermore, if this initial request is routed to a TSO service with a lower version, is that behavior expected?
What problem does this PR solve?
Issue Number: Close #6770
kv proto: #1361
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note