Skip to content

[cp-v7.5.6] scheduler: implement network slow store scheduler #9906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: release-7.5-20251003-v7.5.6
Choose a base branch
from
Open

[cp-v7.5.6] scheduler: implement network slow store scheduler #9906

wants to merge 6 commits into from
+987 −232

Conversation

@okJiang
Copy link
Member

@okJiang okJiang commented Nov 5, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #9866

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. labels Nov 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign husharp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 5, 2025
@okJiang
Copy link
Member Author

okJiang commented Nov 5, 2025

/retest

1 similar comment
@okJiang
Copy link
Member Author

okJiang commented Nov 5, 2025

/retest

@okJiang okJiang marked this pull request as ready for review November 5, 2025 10:03
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2025
bufferflies
bufferflies reviewed Nov 5, 2025
View reviewed changes
tools/pd-ctl/pdctl/command/scheduler.go
if err != nil {
val = value
}
boolVal, err := strconv.ParseBool(value)
Copy link
Contributor

@bufferflies bufferflies Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the type of the val(bool or float)?

Copy link
Member Author

@okJiang okJiang Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both are possible

  • If value is float, ParseFloat will success and ParseBool will fail.
  • If value is bool, ParseFloat will fail and ParseBool will success.

@okJiang okJiang mentioned this pull request Nov 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bufferflies bufferflies bufferflies left review comments

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@okJiang @bufferflies