client: introduce circuit breaker for region calls (#8856) #9913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref tikv#8678 Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
dco-signoff: yes
Member
Author
|
@rleungx This PR has conflicts, I have hold it. |
Contributor
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
ref tikv#8678 Signed-off-by: artem_danilov <[email protected]> Co-authored-by: artem_danilov <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ref tikv#8678 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ref tikv#8678 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ref tikv#8678 Signed-off-by: Ryan Leung <[email protected]>
ref tikv#8678 Signed-off-by: Ryan Leung <[email protected]> fix Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
cherry-pick-8856-to-release-8.5
branch
from
cc0e930 to
f5275a9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #9913 +/- ##
===============================================
+ Coverage 75.87% 77.74% +1.86%
===============================================
Files 467 468 +1
Lines 73920 62544 -11376
===============================================
- Hits 56088 48623 -7465
+ Misses 14272 10345 -3927
- Partials 3560 3576 +16
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
okJiang
reviewed
Dec 2, 2025
Member
|
rest lgtm |
ref tikv#8678 Signed-off-by: Ryan Leung <[email protected]>
okJiang
approved these changes
Dec 3, 2025
bufferflies
reviewed
Dec 10, 2025
| @@ -0,0 +1,346 @@ | |||
| // Copyright 2024 TiKV Project Authors. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright 2024 TiKV Project Authors. | |
| // Copyright 2025 TiKV Project Authors. |
bufferflies
approved these changes
Dec 10, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
and removed
needs-1-more-lgtm
Contributor
[LGTM Timeline notifier]Timeline:
|
Member
|
/hold cancel |
ti-chi-bot
bot
added
cherry-pick-approved
Member
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
Member
|
/hold cancel |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8856
What problem does this PR solve?
Issue Number: Ref #8678, tikv/rfcs#115
What is changed and how does it work?
This PR implements circuit breaker from tikv/rfcs#115 and integrates it into http and grpc PD clients for get region metadata calls, but disabled by default.
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note